Skip to content

Conversation

@noferini
Copy link
Collaborator

@noferini noferini commented Feb 8, 2021

Mainly to fix CTF encoding from digits.
Diagnostic patterns moved to 8bit words to deal with 26bit limits

@noferini noferini requested a review from a team as a code owner February 8, 2021 16:09
@noferini
Copy link
Collaborator Author

noferini commented Feb 8, 2021

The last changes were tested on the raw data collected by cosmic runs (MW1).
With this fix we are able to write and read CTF for real data.

@noferini
Copy link
Collaborator Author

noferini commented Feb 9, 2021

errored checks seem not be related to this PR...

@davidrohr
Copy link
Collaborator

This PR should be fine, it was built correctly in o2-dataflow.
If you want to keep both commits separate, please manually squash the formatting commit in there. Otherwise the PR should be squashed when merging.

@noferini
Copy link
Collaborator Author

noferini commented Feb 9, 2021

I did a squash of the commits

@shahor02
Copy link
Collaborator

shahor02 commented Feb 9, 2021

Hi @noferini
could you please fix this?

/mnt/mesos/sandbox/sandbox/o2-fullci/sw/SOURCES/O2/5410/0/Detectors/TOF/base/src/WindowFiller.cxx:305:52: warning: statement should be inside braces [readability-braces-around-statements]
      if (mReadoutWindowData.size() < nwindowperTF)

@noferini
Copy link
Collaborator Author

Hi @noferini
could you please fix this?

/mnt/mesos/sandbox/sandbox/o2-fullci/sw/SOURCES/O2/5410/0/Detectors/TOF/base/src/WindowFiller.cxx:305:52: warning: statement should be inside braces [readability-braces-around-statements]
      if (mReadoutWindowData.size() < nwindowperTF)

Done

@shahor02
Copy link
Collaborator

failures unrelated

@shahor02 shahor02 merged commit 4b94f71 into AliceO2Group:dev Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants