Changed log message from WARNING to DEBUG. #5414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrosseo
approved these changes
Feb 9, 2021
ktf
requested changes
Feb 10, 2021
Member
ktf
left a comment
ktf
left a comment
There was a problem hiding this comment.
Rather than demoting it, can we please print only the first one?
Member
|
Or only the message 1, 10, 100, 1000... etc? |
Collaborator
|
I think it is completely normal behavior to have an empty table in a filtering. Or is this message covering a different case? |
Member
|
Empty table, yes, empty payload, I am not sure. I missed this is just in the AOD writer though. So I guess it's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happens that messages with empty payload arrive at the aod-writer. These messages are skipped. However, so far a WARNING log was created which seems to have caused some confusion for users. The log message is hence changed from WARNING to DEBUG.
The fact that messages with empty payload are passed to the writer might however need further investigation.