Skip to content

Apply git clang-format to Analysis. #5420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jgrosseo merged 1 commit into from
Feb 11, 2021
Merged

Apply git clang-format to Analysis. #5420

jgrosseo merged 1 commit into from
Feb 11, 2021

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented Feb 9, 2021

No description provided.

@vkucera vkucera marked this pull request as ready for review February 9, 2021 14:33
jgrosseo
jgrosseo previously approved these changes Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@jgrosseo jgrosseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK but do we usually apply clang to the linkdef files?

@vkucera
Copy link
Collaborator Author

vkucera commented Feb 9, 2021

This is OK but do we usually apply clang to the linkdef files?

I am relying on the configuration in the repository to know better which files should be checked.
I just ran git clang-format against the first O2 commit.

@vkucera
Copy link
Collaborator Author

vkucera commented Feb 9, 2021

But in general, is there a reason to not check them?

@vkucera
Copy link
Collaborator Author

vkucera commented Feb 10, 2021 •
edited
Loading

  • Reformatted with clang-format 11.
  • Reverted changes conflicting with the GitHub check. (It doesn't apply the same rules for some reason.)

@vkucera vkucera requested a review from jgrosseo February 10, 2021 02:04
@vkucera
Copy link
Collaborator Author

vkucera commented Feb 11, 2021

Bump

@jgrosseo jgrosseo merged commit 86f7ddc into AliceO2Group:dev Feb 11, 2021
@vkucera vkucera deleted the clang-analysis branch February 18, 2021 12:25
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
@vkucera @jgrosseo
Apply git clang-format to Analysis. (AliceO2Group#5420)
d6bb445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgrosseo jgrosseo jgrosseo approved these changes

@iarsene iarsene Awaiting requested review from iarsene

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vkucera @jgrosseo