[PWGHF] Add ml features and create a small table for local analysis. #11202
Conversation
FDUEnrich
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
vkucera and
zhangbiao-phy
as code owners
|
O2 linter results: ❌ 1 errors, |
github-actions
bot
changed the title
Please consider the following formatting changes to AliceO2Group#11202
zhangbiao-phy
left a comment
zhangbiao-phy
left a comment
There was a problem hiding this comment.
hi @FDUEnrich, Thanks for the updates! I just have minor comments as below.
| DECLARE_SOA_COLUMN(TofNSigmaPrFromLambda, tofNSigmaPrFromLambda, float); | ||
| DECLARE_SOA_COLUMN(PidTpcInfoStored, pidTpcInfoStored, int); | ||
| DECLARE_SOA_COLUMN(PidTofInfoStored, pidTofInfoStored, int); | ||
| // Machine learning column for omegac0 to omega pi |
There was a problem hiding this comment.
Why do we need to separate Omegac and OmegacBar here (not related to this PR)? maybe remove it, then you just keep and use MlProbOmegac .
There was a problem hiding this comment.
It was created by Yunfan. I'm not sure if it's useful, so I just remain it.
There was a problem hiding this comment.
Hi @FDUEnrich, I think we can remove MlProbOmegacBar and MlValueOmegac; just keep and use MlProbOmegac for simplicity. @Yunfan-Liu is it Ok for you? For Omegac, we don't need to separate particle and antiparticle, since we don't have the combination of the mass hypothesis.
There was a problem hiding this comment.
Hi @FDUEnrich, I think we can remove
MlProbOmegacBarandMlValueOmegac; just keep and useMlProbOmegacfor simplicity. @Yunfan-Liu is it Ok for you? For Omegac, we don't need to separate particle and antiparticle, since we don't have the combination of the mass hypothesis.
Hi @FDUEnrich and @zhangbiao-phy , remove MlProbOmegacBar is fine for me.
Co-authored-by: BiaoZhang (张彪) <52267892+zhangbiao-phy@users.noreply.github.com>
| hf_sel_toomegapi::MlProbOmegac); | ||
| hf_sel_toomegapi::mlValueOmegac); |
There was a problem hiding this comment.
This will not compile. Don't push changes without local testing!
…liceO2Group#11202) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: BiaoZhang (张彪) <52267892+zhangbiao-phy@users.noreply.github.com>
…liceO2Group#11202) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: BiaoZhang (张彪) <52267892+zhangbiao-phy@users.noreply.github.com>
…liceO2Group#11202) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: BiaoZhang (张彪) <52267892+zhangbiao-phy@users.noreply.github.com>
…liceO2Group#11202) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: BiaoZhang (张彪) <52267892+zhangbiao-phy@users.noreply.github.com>
…liceO2Group#11202) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: BiaoZhang (张彪) <52267892+zhangbiao-phy@users.noreply.github.com>
…liceO2Group#11202) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: BiaoZhang (张彪) <52267892+zhangbiao-phy@users.noreply.github.com>
…liceO2Group#11202) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: BiaoZhang (张彪) <52267892+zhangbiao-phy@users.noreply.github.com>
5 participants
No description provided.