[PWGHF] Add omegac0 xic0 to omega ka framework reconstructed by kf #11764
Conversation
github-actions
bot
changed the title
|
O2 linter results: ❌ 6 errors, |
Please consider the following formatting changes to AliceO2Group#11764
FDUEnrich
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
vkucera and
zhangbiao-phy
as code owners
fgrosa
left a comment
fgrosa
left a comment
There was a problem hiding this comment.
Hi @FDUEnrich thanks for the implementation! As a general comment, I think it would have been beneficial to have a single process function for Omega+Pi and Omega+Ka (and also for Xi and Omega actually), where only the PID selection and the mass hypothesis is different for the bachelor, to avoid a large amount of code duplication, which is much more difficult to maintain. However since the other cases are already split we can keep this strategy (but it would be good to improve this sooner or later).
In the following you can see my detailed comments to your additionss
| auto trackKaFromOmega = casc.bachelor_as<MyKfTracks>(); // Ka <- Omega track | ||
| auto trackV0DauPos = casc.posTrack_as<MyKfTracks>(); // V0 positive daughter track | ||
| auto trackV0DauNeg = casc.negTrack_as<MyKfTracks>(); // V0 negative daughter track | ||
| auto KaFromOmegaCharge = trackKaFromOmega.signed1Pt() > 0 ? +1 : -1; |
There was a problem hiding this comment.
Why can't you use the trackKaFromOmega.sign() directly?
There was a problem hiding this comment.
@FDUEnrich did you check if you can use trackKaFromOmega.sign() directly instead of defining a new variable?
| auto trackV0DauPos = casc.posTrack_as<MyKfTracks>(); // V0 positive daughter track | ||
| auto trackV0DauNeg = casc.negTrack_as<MyKfTracks>(); // V0 negative daughter track | ||
| auto KaFromOmegaCharge = trackKaFromOmega.signed1Pt() > 0 ? +1 : -1; | ||
| int signOmega = casc.sign() > 0 ? +1 : -1; |
There was a problem hiding this comment.
Why can't you use casc.sign() directly?
…ework-reconstructed-by-KF
…ework-reconstructed-by-KF
Please consider the following formatting changes to AliceO2Group#11764
Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
|
@FDUEnrich Please fix the errors. |
…liceO2Group#11764) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
…liceO2Group#11764) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
…liceO2Group#11764) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
…liceO2Group#11764) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
…liceO2Group#11764) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
…liceO2Group#11764) Co-authored-by: ALICE Action Bot <alibuild@cern.ch> Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
4 participants
No description provided.