[PWGJE] [EMCAL] introducing zorro to emcal correction framework #14674
+86
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjonasALICE
requested review from
alibuild,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
github-actions
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running over skimmed/triggered data, where an analysis is only interested in a certain set of software triggers, the EMCal correction framework will always run over all events, which comes with a significant CPU overhead.
I added the ability to enable (optionally) "applySoftwareTriggerSelection" , which will cause the correction framework to only process events that fulfill the list of software triggers given in "softwareTriggerSelection" .
If enabled, everything is implemented in a way that the whole correction framework will never see/process other events not fulfilled by the trigger, i.e. BCs that don't fulfill the triggers are skipped and collisions associated with a bc that was not triggered are skipped.
Tested locally on 2023 skimmed pp data, requiring the high pt gamma triggers results in a speedup of a factor 6.8! (212s for 4 files vs 31s for 4 files