-
Notifications
You must be signed in to change notification settings - Fork 158
Add TPC Tracking QA Task #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Barthelemy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the code is in O2, what I see here is ok.
|
The code here is OK, but it canot be used yet. We need:
|
|
OK, I propose to "WIP" it then. |
|
OK, just wanted to see whether it passes the CI or if I still have to do something, therefore no WIP :) |
|
Hi @davidrohr, unfortunately I think I cannot help you much, since we haven't had a look at MC labels, yet. Concerning the trackreader: If this is the way you want to go instead of taking the data directly from the reco-workflow I think it should be possible to add another output (TPCTracksMCTruth) to the reader. How exactly this would look like I do not know but feel free to modify the reader (QualityControl/Modules/TPC/run/runTPCQCTrackReader.cxx). Concerning the cluster MC labels: Afaik there is nothing implemented in the QC so far to easily provide MC labels for the clusters. At least not from our side or anyone else that I know of. |
|
@tklemenz : Yes, I think we should modify the o2-qc-run-tpctrackreader to provide the mc track labels as a second output. |
db2a782 to
8550e94
Compare
|
@Barthelemy : This is now fully working and ready to be merged. |
@wiechula @stheckel @tklemenz : This adds the standalone TPC QA task to QC (needs AliceO2Group/AliceO2#4846)
o2-qc-run-tpctrackreaderIn addition, I would need:
o2-qc-run-tpctrackreadersomehow).