Skip to content

feat(node): add IP pool sync period configuration#857

Merged
BSWANG merged 1 commit intoAliyunContainerService:mainfrom
l1b0k:feat/ip
Jul 24, 2025
Merged

feat(node): add IP pool sync period configuration#857
BSWANG merged 1 commit intoAliyunContainerService:mainfrom
l1b0k:feat/ip

Conversation

@l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Jul 24, 2025

  • Add poolSyncPeriod field to Node CRD
  • Implement logic to parse and use custom sync period from Node spec
  • Update ENI manager to use the new sync period configuration- Add default value and validation for the new configuration

@l1b0k l1b0k requested a review from BSWANG July 24, 2025 09:35
@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 45.83333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 35.57%. Comparing base (8e919e2) to head (9b2810c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
types/daemon/config.go 0.00% 6 Missing ⚠️
pkg/controller/multi-ip/node/pool.go 72.72% 1 Missing and 2 partials ⚠️
pkg/eni/node_reconcile.go 50.00% 3 Missing ⚠️
daemon/builder.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
+ Coverage   35.55%   35.57%   +0.01%     
==========================================
  Files         130      130              
  Lines       18837    18850      +13     
==========================================
+ Hits         6698     6706       +8     
- Misses      11388    11394       +6     
+ Partials      751      750       -1     
Flag Coverage Δ
unittests 35.57% <45.83%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Add poolSyncPeriod field to Node CRD
- Implement logic to parse and use custom sync period from Node spec
- Update ENI manager to use the new sync period configuration- Add default value and validation for the new configuration

Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
@BSWANG BSWANG merged commit 67b150b into AliyunContainerService:main Jul 24, 2025
9 checks passed
@l1b0k l1b0k deleted the feat/ip branch July 24, 2025 10:36
cursor bot pushed a commit that referenced this pull request Sep 7, 2025
feat(node): add IP pool sync period configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants