Skip to content

feat(crdv2): implement node change notification mechanism#872

Merged
BSWANG merged 1 commit intoAliyunContainerService:mainfrom
l1b0k:feat/ipam
Aug 21, 2025
Merged

feat(crdv2): implement node change notification mechanism#872
BSWANG merged 1 commit intoAliyunContainerService:mainfrom
l1b0k:feat/ipam

Conversation

@l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Aug 19, 2025

  • Add Notifier and Subscription interfaces for node change notifications
  • Integrate notifications with CRDV2 to improve IP allocation efficiency
  • Refactor IP allocation logic to use the new notification system
  • Optimize performance by reducing unnecessary API calls and improving concurrency

@l1b0k l1b0k requested a review from BSWANG August 19, 2025 12:05
@l1b0k l1b0k force-pushed the feat/ipam branch 2 times, most recently from 9120dfd to 61eb6d9 Compare August 19, 2025 12:16
@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 74.86911% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.74%. Comparing base (ff107f0) to head (c6538a9).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/eni/crdv2.go 68.29% 26 Missing and 13 partials ⚠️
pkg/eni/notify.go 86.76% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
+ Coverage   44.55%   45.74%   +1.18%     
==========================================
  Files         130      131       +1     
  Lines       18988    19087      +99     
==========================================
+ Hits         8460     8731     +271     
+ Misses       9634     9442     -192     
- Partials      894      914      +20     
Flag Coverage Δ
unittests 45.74% <74.86%> (+1.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@l1b0k l1b0k force-pushed the feat/ipam branch 2 times, most recently from 0c04210 to 8f50d06 Compare August 20, 2025 03:46
- Add Notifier and Subscription interfaces for node change notifications- Integrate notifications with CRDV2 to improve IP allocation efficiency
- Refactor IP allocation logic to use the new notification system
- Optimize performance by reducing unnecessary API calls and improving concurrency

Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
@BSWANG BSWANG merged commit 89befd9 into AliyunContainerService:main Aug 21, 2025
17 checks passed
@l1b0k l1b0k deleted the feat/ipam branch August 21, 2025 06:16
cursor bot pushed a commit that referenced this pull request Sep 7, 2025
feat(crdv2): implement node change notification mechanism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants