fix(aliyun): handle not found error for eni delete operation#873
Merged
BSWANG merged 1 commit intoAliyunContainerService:mainfrom Aug 19, 2025
Merged
fix(aliyun): handle not found error for eni delete operation#873BSWANG merged 1 commit intoAliyunContainerService:mainfrom
BSWANG merged 1 commit intoAliyunContainerService:mainfrom
Conversation
Collaborator
l1b0k
commented
Aug 19, 2025
- Add error handling for 'InvalidEniId.NotFound' in the ENI delete operation
- Log a success message and return nil when the ENI is already deleted
- Improve error logging by including the request ID
- Add error handling for 'InvalidEniId.NotFound' in the ENI delete operation - Log a success message and return nil when the ENI is already deleted - Improve error logging by including the request ID Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
==========================================
- Coverage 44.56% 44.55% -0.01%
==========================================
Files 130 130
Lines 18984 18988 +4
==========================================
Hits 8460 8460
- Misses 9630 9634 +4
Partials 894 894
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BSWANG
approved these changes
Aug 19, 2025
cursor bot
pushed a commit
that referenced
this pull request
Sep 7, 2025
fix(aliyun): handle not found error for eni delete operation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.