Skip to content

fix(aliyun): handle not found error for eni delete operation#873

Merged
BSWANG merged 1 commit intoAliyunContainerService:mainfrom
l1b0k:feat/code
Aug 19, 2025
Merged

fix(aliyun): handle not found error for eni delete operation#873
BSWANG merged 1 commit intoAliyunContainerService:mainfrom
l1b0k:feat/code

Conversation

@l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Aug 19, 2025

  • Add error handling for 'InvalidEniId.NotFound' in the ENI delete operation
  • Log a success message and return nil when the ENI is already deleted
  • Improve error logging by including the request ID

- Add error handling for 'InvalidEniId.NotFound' in the ENI delete operation
- Log a success message and return nil when the ENI is already deleted
- Improve error logging by including the request ID

Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.55%. Comparing base (23cef2a) to head (ff107f0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/aliyun/client/ecs.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
- Coverage   44.56%   44.55%   -0.01%     
==========================================
  Files         130      130              
  Lines       18984    18988       +4     
==========================================
  Hits         8460     8460              
- Misses       9630     9634       +4     
  Partials      894      894              
Flag Coverage Δ
unittests 44.55% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BSWANG BSWANG merged commit afcd6be into AliyunContainerService:main Aug 19, 2025
6 of 9 checks passed
@l1b0k l1b0k deleted the feat/code branch August 20, 2025 06:12
cursor bot pushed a commit that referenced this pull request Sep 7, 2025
fix(aliyun): handle not found error for eni delete operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants