Skip to content

add ecs, eflo controller v2 client #874

Merged
BSWANG merged 2 commits intoAliyunContainerService:mainfrom
l1b0k:feat/eni
Aug 21, 2025
Merged

add ecs, eflo controller v2 client #874
BSWANG merged 2 commits intoAliyunContainerService:mainfrom
l1b0k:feat/eni

Conversation

@l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Aug 20, 2025

No description provided.

- Implement ECSV2Client interface and ecsV2ClientImpl struct
- Add NewECSV2Client function to create ECS v2 client
- Update ClientMgr to include ECSV2Client
- Modify wire.go and wire_gen.go to integrate ECS v2 client
- Update go.mod and go.sum to include ecs-20140526/v7 dependency

Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.81%. Comparing base (ff107f0) to head (08d6861).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
pkg/aliyun/credential/clients.go 55.88% 20 Missing and 10 partials ⚠️
pkg/aliyun/credential/wire_gen.go 66.66% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
+ Coverage   44.55%   44.81%   +0.25%     
==========================================
  Files         130      130              
  Lines       18988    19070      +82     
==========================================
+ Hits         8460     8546      +86     
+ Misses       9634     9624      -10     
- Partials      894      900       +6     
Flag Coverage Δ
unittests 44.81% <60.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Implement EFLO Controller client in aliyun package
- Add new client to ClientMgr and update related files
- Update go.mod and go.sum for new dependency

Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
@BSWANG BSWANG merged commit 7699b01 into AliyunContainerService:main Aug 21, 2025
9 checks passed
@l1b0k l1b0k deleted the feat/eni branch August 26, 2025 07:55
cursor bot pushed a commit that referenced this pull request Sep 7, 2025
add ecs, eflo controller v2 client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants