Skip to content

feat(controller): add check for daemon support of node runtime#878

Merged
BSWANG merged 1 commit intoAliyunContainerService:mainfrom
l1b0k:feat/enhance_dataplan
Sep 1, 2025
Merged

feat(controller): add check for daemon support of node runtime#878
BSWANG merged 1 commit intoAliyunContainerService:mainfrom
l1b0k:feat/enhance_dataplan

Conversation

@l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Sep 1, 2025

  • Implement function to check if the daemon on a node supports runtime
  • Add logic to skip IP allocation for pods if daemon does not support node runtime
  • Introduce atomic boolean to cache daemon support status per node- Update IP allocation logic to use the new daemon support check

@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.82%. Comparing base (2cbb868) to head (dcbcb6d).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/multi-ip/node/pool.go 85.71% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
+ Coverage   46.70%   46.82%   +0.11%     
==========================================
  Files         132      132              
  Lines       19447    19513      +66     
==========================================
+ Hits         9082     9136      +54     
- Misses       9435     9444       +9     
- Partials      930      933       +3     
Flag Coverage Δ
unittests 46.82% <85.71%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@l1b0k l1b0k force-pushed the feat/enhance_dataplan branch from 5c49644 to 2478e4f Compare September 1, 2025 07:15
- Implement function to check if the daemon on a node supports runtime
- Add logic to skip IP allocation for pods if daemon does not support node runtime
- Introduce atomic boolean to cache daemon support status per node- Update IP allocation logic to use the new daemon support check

Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
@l1b0k l1b0k force-pushed the feat/enhance_dataplan branch from 2478e4f to dcbcb6d Compare September 1, 2025 07:17
@BSWANG BSWANG requested a review from Copilot September 1, 2025 07:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements daemon support detection for node runtime by checking the terway daemon version. The implementation adds logic to determine if the daemon supports NodeRuntime resources and conditionally skips IP allocation for pods when the daemon lacks this support.

Key changes:

  • Add version-based daemon support detection using semver comparison against v1.11.3
  • Modify IP release logic to handle cases where NodeRuntime is not supported
  • Implement comprehensive test coverage for the daemon support detection function

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pkg/controller/multi-ip/node/pool.go Adds daemon support detection logic and modifies IP release flow to conditionally use NodeRuntime
pkg/controller/multi-ip/node/pool_test.go Adds comprehensive test cases for the daemon support detection function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@BSWANG BSWANG merged commit d0d421e into AliyunContainerService:main Sep 1, 2025
9 checks passed
@l1b0k l1b0k deleted the feat/enhance_dataplan branch September 3, 2025 01:54
cursor bot pushed a commit that referenced this pull request Sep 7, 2025
feat(controller): add check for daemon support of node runtime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants