feat(controller): add check for daemon support of node runtime#878
Conversation
l1b0k
commented
Sep 1, 2025
- Implement function to check if the daemon on a node supports runtime
- Add logic to skip IP allocation for pods if daemon does not support node runtime
- Introduce atomic boolean to cache daemon support status per node- Update IP allocation logic to use the new daemon support check
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
==========================================
+ Coverage 46.70% 46.82% +0.11%
==========================================
Files 132 132
Lines 19447 19513 +66
==========================================
+ Hits 9082 9136 +54
- Misses 9435 9444 +9
- Partials 930 933 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5c49644 to
2478e4f
Compare
- Implement function to check if the daemon on a node supports runtime - Add logic to skip IP allocation for pods if daemon does not support node runtime - Introduce atomic boolean to cache daemon support status per node- Update IP allocation logic to use the new daemon support check Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
2478e4f to
dcbcb6d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements daemon support detection for node runtime by checking the terway daemon version. The implementation adds logic to determine if the daemon supports NodeRuntime resources and conditionally skips IP allocation for pods when the daemon lacks this support.
Key changes:
- Add version-based daemon support detection using semver comparison against v1.11.3
- Modify IP release logic to handle cases where NodeRuntime is not supported
- Implement comprehensive test coverage for the daemon support detection function
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/controller/multi-ip/node/pool.go | Adds daemon support detection logic and modifies IP release flow to conditionally use NodeRuntime |
| pkg/controller/multi-ip/node/pool_test.go | Adds comprehensive test cases for the daemon support detection function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
feat(controller): add check for daemon support of node runtime