add host_stack_cidrs support in datapathv2#879
add host_stack_cidrs support in datapathv2#879BSWANG merged 3 commits intoAliyunContainerService:mainfrom
Conversation
- Remove hardcoded LOCAL_DNS_IP in bpf_lxc.c - Add TerwayHostStackCIDR option in daemon_main.go - Update hostips-sync.go to use configurable CIDR - Add HostStackCIDRs to option/config.go Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
6913891 to
24b925a
Compare
Codecov Report❌ Patch coverage is
❌ Your project status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
==========================================
- Coverage 46.84% 46.80% -0.04%
==========================================
Files 132 132
Lines 19513 19523 +10
==========================================
- Hits 9140 9137 -3
- Misses 9441 9451 +10
- Partials 932 935 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Introduce HostStackCIDRs configuration option in PolicyConfig - Validate and parse host stack CIDRs - Append host stack CIDRs to ciliumArgs Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
- Update image tag from policy-ce3481dc to policy-381dd606 Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
24b925a to
7f4b3db
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for multiple host stack CIDRs in Cilium's datapathv2 mode for the Terway CNI plugin. The implementation adds a new BPF map to handle multiple host stack CIDR ranges instead of relying on a single hardcoded IP address.
- Add new BPF map
terway_host_stack_cidrwith LPM trie structure for efficient CIDR lookups - Implement host stack CIDR management functions in Go including map initialization and CIDR entry management
- Update configuration handling to support multiple host stack CIDRs via command line arguments and CNI configuration
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/kind/conf/*.cmdline | Add --terway-host-stack-cidr=169.254.20.10/32 parameter to test configuration files |
| policy/cilium/0014-feat-datapath-add-multi-host-stack-support-for-veth-.patch | Contains the main implementation patch with BPF map definition, daemon initialization logic, and configuration parsing |
| deploy/images/*/Dockerfile | Update Terway policy image reference to newer version with host stack CIDR support |
| cmd/terway-cli/policy.go | Add support for parsing host_stack_cidrs from CNI configuration and generating appropriate cilium arguments |
| cmd/terway-cli/policy_test.go | Add test cases for host stack CIDR configuration scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
policy/cilium/0014-feat-datapath-add-multi-host-stack-support-for-veth-.patch
Show resolved
Hide resolved
policy/cilium/0014-feat-datapath-add-multi-host-stack-support-for-veth-.patch
Show resolved
Hide resolved
policy/cilium/0014-feat-datapath-add-multi-host-stack-support-for-veth-.patch
Show resolved
Hide resolved
policy/cilium/0014-feat-datapath-add-multi-host-stack-support-for-veth-.patch
Show resolved
Hide resolved
policy/cilium/0014-feat-datapath-add-multi-host-stack-support-for-veth-.patch
Show resolved
Hide resolved
policy/cilium/0014-feat-datapath-add-multi-host-stack-support-for-veth-.patch
Show resolved
Hide resolved
add host_stack_cidrs support in datapathv2
No description provided.