test(smc): add unit tests for SMC-R networking functionality#891
Merged
l1b0k merged 1 commit intoAliyunContainerService:mainfrom Sep 9, 2025
Merged
test(smc): add unit tests for SMC-R networking functionality#891l1b0k merged 1 commit intoAliyunContainerService:mainfrom
l1b0k merged 1 commit intoAliyunContainerService:mainfrom
Conversation
Collaborator
l1b0k
commented
Sep 8, 2025
- Implement comprehensive unit tests for SMC-R networking features
- Cover various scenarios including success and failure cases
- Mock system commands and file operations for isolated testing
- Use testify/assert for test assertions
- Include tests for ensuring SMC-R support, configuring devices, and handling errors
BSWANG
approved these changes
Sep 9, 2025
- Implement comprehensive unit tests for SMC-R networking features - Cover various scenarios including success and failure cases - Mock system commands and file operations for isolated testing - Use testify/assert for test assertions - Include tests for ensuring SMC-R support, configuring devices, and handling errors Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #891 +/- ##
==========================================
+ Coverage 53.48% 53.75% +0.27%
==========================================
Files 132 132
Lines 19523 19523
==========================================
+ Hits 10441 10495 +54
+ Misses 8024 7970 -54
Partials 1058 1058
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.