Merged
Conversation
- Implement unit tests for the runCalico function in policy_test.go - Use gomonkey to mock exec.LookPath and syscall.Exec for testing - Verify error handling for missing calico-felix and execution failures - Test setting of environment variables for calico-felix Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
…it tests for runCilium function in policy_test.go - Test various scenarios including successful execution, error cases, and argument/environment verification - Use gomonkey for mocking os.ReadFile, exec.LookPath, and syscall.Exec - Validate correct arguments and environment variables are set for cilium-agent Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
==========================================
+ Coverage 53.48% 54.09% +0.60%
==========================================
Files 132 132
Lines 19523 19523
==========================================
+ Hits 10441 10560 +119
+ Misses 8024 7905 -119
Partials 1058 1058
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.