Merged
Conversation
- Implement comprehensive unit tests for the AllocIP function in the daemon package - Cover various scenarios including successful allocation, errors, and edge cases - Use mocking to isolate dependencies and focus on function logic - Improve test coverage and ensure function reliability Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
- Implement comprehensive unit tests for the ReleaseIP function- Cover various scenarios including successful releases, pod not found, errors in resource retrieval and deletion - Test both ENIMultiIP and VPCENI pod network types - Validate behavior for different IP stick times and IPAM types Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
- Implement comprehensive tests for GetIPInfo function in server_test.go - Cover various scenarios including successful cases, errors, and edge cases - Use mocking to simulate different conditions and dependencies - Add tests for both ENIMultiIP and VPCENI pod network types - Include error cases such as pod not found, resource retrieval failure, and unknown network types - Test container ID mismatch and invalid JSON netconf handling Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
==========================================
+ Coverage 55.81% 58.53% +2.72%
==========================================
Files 131 131
Lines 19517 19517
==========================================
+ Hits 10893 11425 +532
+ Misses 7537 6960 -577
- Partials 1087 1132 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.