Skip to content

feat(terway): add WriteCNIConfFirst feature gate#915

Merged
BSWANG merged 1 commit intoAliyunContainerService:mainfrom
l1b0k:feat/cni
Sep 29, 2025
Merged

feat(terway): add WriteCNIConfFirst feature gate#915
BSWANG merged 1 commit intoAliyunContainerService:mainfrom
l1b0k:feat/cni

Conversation

@l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Sep 29, 2025

  • Introduce new feature gate for writing CNI configuration first
  • Implement feature gate parsing and setting in main.go
  • Add condition to skip CNI configuration writing in server.go
  • Update hack/init.sh script to handle WriteCNIConfFirst flag
  • Register WriteCNIConfFirst feature in feature.go

- Introduce new feature gate for writing CNI configuration first
- Implement feature gate parsing and setting in main.go
- Add condition to skip CNI configuration writing in server.go
- Update hack/init.sh script to handle WriteCNIConfFirst flag
- Register WriteCNIConfFirst feature in feature.go

Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.39%. Comparing base (a19db68) to head (eb28f6d).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cmd/terway/main.go 0.00% 7 Missing ⚠️
daemon/server.go 0.00% 3 Missing and 1 partial ⚠️

❌ Your project status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   59.44%   59.39%   -0.05%     
==========================================
  Files         131      131              
  Lines       19545    19556      +11     
==========================================
- Hits        11618    11616       -2     
- Misses       6779     6790      +11     
- Partials     1148     1150       +2     
Flag Coverage Δ
unittests 59.39% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BSWANG BSWANG merged commit 4f8395a into AliyunContainerService:main Sep 29, 2025
7 of 9 checks passed
@l1b0k l1b0k deleted the feat/cni branch October 9, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants