Skip to content

test: update assessment names to reflect correct traffic direction #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BSWANG merged 1 commit into from
Oct 28, 2025
Merged

test: update assessment names to reflect correct traffic direction #929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions tests/connective_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,15 +325,17 @@ func TestNormal_NetworkPolicy(t *testing.T) {
}

for _, stack := range getStack() {
t.Logf("Testing %s: client should be able to access server (normal traffic, no policy applied)", stack)
_, err = Pull(config.Client(), client.Namespace, client.Name, "client", "server-"+stack, t)
if err != nil {
t.Error(err)
t.Errorf("Expected: client can access server (%s), but failed: %v", stack, err)
t.FailNow()
}

t.Logf("Testing %s: client should NOT be able to access server-deny-ingress (ingress policy denies traffic to deny-ingress pods)", stack)
_, err = PullFail(config.Client(), client.Namespace, client.Name, "client", "server-deny-ingress-"+stack, t)
if err != nil {
t.Error(err)
t.Errorf("Expected: client cannot access server-deny-ingress (%s), but connection succeeded: %v", stack, err)
t.FailNow()
}
}
Expand Down Expand Up @@ -396,15 +398,17 @@ func TestNormal_NetworkPolicy(t *testing.T) {
}

for _, stack := range getStack() {
t.Logf("Testing %s: client-other should be able to access server-other (normal traffic, no policy applied)", stack)
_, err = Pull(config.Client(), client.Namespace, client.Name, "client", "server-"+stack, t)
if err != nil {
t.Error(err)
t.Errorf("Expected: client-other can access server-other (%s), but failed: %v", stack, err)
t.FailNow()
}

t.Logf("Testing %s: client-other should NOT be able to access server-deny-ingress-other (ingress policy denies traffic to deny-ingress-other pods)", stack)
_, err = PullFail(config.Client(), client.Namespace, client.Name, "client", "server-deny-ingress-"+stack, t)
if err != nil {
t.Error(err)
t.Errorf("Expected: client-other cannot access server-deny-ingress-other (%s), but connection succeeded: %v", stack, err)
t.FailNow()
}
}
Expand Down Expand Up @@ -448,7 +452,7 @@ func TestNormal_NetworkPolicy(t *testing.T) {
ctx = SaveResources(ctx, objs...)
return ctx
}).
Assess("Check ingress policy", func(ctx context.Context, t *testing.T, config *envconf.Config) context.Context {
Assess("Check egress policy", func(ctx context.Context, t *testing.T, config *envconf.Config) context.Context {
client := &corev1.Pod{ObjectMeta: metav1.ObjectMeta{Name: "client", Namespace: config.Namespace()}}
server := &corev1.Pod{ObjectMeta: metav1.ObjectMeta{Name: "server", Namespace: config.Namespace()}}
err := waitPodsReady(config.Client(), client, server)
Expand All @@ -458,9 +462,10 @@ func TestNormal_NetworkPolicy(t *testing.T) {
}

for _, stack := range getStack() {
t.Logf("Testing %s: client should NOT be able to access server (egress policy denies all outbound traffic from client)", stack)
_, err = PullFail(config.Client(), client.Namespace, client.Name, "client", "server-"+stack, t)
if err != nil {
t.Error(err)
t.Errorf("Expected: client cannot access server (%s), but connection succeeded: %v", stack, err)
t.FailNow()
}
}
Expand Down Expand Up @@ -504,7 +509,7 @@ func TestNormal_NetworkPolicy(t *testing.T) {
ctx = SaveResources(ctx, objs...)
return ctx
}).
Assess("Check ingress policy", func(ctx context.Context, t *testing.T, config *envconf.Config) context.Context {
Assess("Check egress policy", func(ctx context.Context, t *testing.T, config *envconf.Config) context.Context {
client := &corev1.Pod{ObjectMeta: metav1.ObjectMeta{Name: "client", Namespace: config.Namespace()}}
server := &corev1.Pod{ObjectMeta: metav1.ObjectMeta{Name: "server", Namespace: config.Namespace()}}
err := waitPodsReady(config.Client(), client, server)
Expand All @@ -514,9 +519,10 @@ func TestNormal_NetworkPolicy(t *testing.T) {
}

for _, stack := range getStack() {
t.Logf("Testing %s: client should NOT be able to access server (egress policy denies all outbound traffic from client)", stack)
_, err = PullFail(config.Client(), client.Namespace, client.Name, "client", "server-"+stack, t)
if err != nil {
t.Error(err)
t.Errorf("Expected: client cannot access server (%s), but connection succeeded: %v", stack, err)
t.FailNow()
}
}
Expand Down