Skip to content

feat(tests): add checks for terway daemonset name and version requirements in tests#940

Merged
BSWANG merged 1 commit intoAliyunContainerService:mainfrom
l1b0k:main
Nov 24, 2025
Merged

feat(tests): add checks for terway daemonset name and version requirements in tests#940
BSWANG merged 1 commit intoAliyunContainerService:mainfrom
l1b0k:main

Conversation

@l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Nov 24, 2025

Note

Add daemonset/name and version checks to e2e tests (incl. k8s version for HostPort) and introduce Makefile targets to run e2e suites.

  • E2E Tests:
    • Add gating for terway daemonset name (terway-eniip) and minimum versions.
      • Utilities in tests/utils_test.go: GetTerwayDaemonSetName, GetTerwayVersion, GetK8sVersion, CheckTerwayDaemonSetName, CheckTerwayVersion.
    • Apply checks in:
      • tests/config_test.go (IPPool): require terway-eniip, terway >= v1.16.1.
      • tests/idle_ip_reclaim_test.go: require terway-eniip, terway >= v1.16.1; cleanup fixes.
      • tests/connective_test.go:
        • NetworkPolicy: require terway-eniip.
        • HostPort: require terway-eniip, terway >= v1.15.0, k8s >= v1.34.0; minor err var fix.
      • tests/multi_network_test.go: require terway-eniip, terway >= v1.16.1.
    • tests/main_test.go: minor cleanup of unused flags/vars.
  • Makefile:
    • New targets: e2e-test, e2e-upgrade-test, e2e-test-all to run e2e suites.

Written by Cursor Bugbot for commit 7f5b9c7. This will update automatically on new commits. Configure here.

…ments in tests

Signed-off-by: l1b0k <libokang.lbk@alibaba-inc.com>
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.74%. Comparing base (1144b3e) to head (7f5b9c7).
⚠️ Report is 2 commits behind head on main.

❌ Your project status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #940      +/-   ##
==========================================
- Coverage   61.77%   61.74%   -0.03%     
==========================================
  Files         131      131              
  Lines       16104    16104              
==========================================
- Hits         9948     9944       -4     
- Misses       4984     4988       +4     
  Partials     1172     1172              
Flag Coverage Δ
unittests 61.74% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BSWANG BSWANG merged commit bc5b522 into AliyunContainerService:main Nov 24, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants