feat(eni): add IPStatusInvalid and update status handling for invalid…

[l1b0k]

… IPs

---

Note

Introduce Invalid IP status and update ENI sync/release logic to mark in-use missing IPs invalid, keep primary IPs, and transition invalid IPs to deleting; bump Node CRD to v0.6.1.

• API/CRDs:
  • Add Invalid to IP status enum in pkg/apis/crds/network.alibabacloud.com_nodes.yaml (IPv4/IPv6).
  • Bump CRDNode version to v0.6.1 in pkg/apis/crds/register.go.
  • Define IPStatusInvalid in pkg/apis/network.alibabacloud.com/v1beta1/node_types.go and update validation enum.
• Controller (multi-ip node):
  • mergeIPMap: preserve primary IPs missing from remote; mark in-use missing IPs as Invalid; delete others.
  • releasePodNotFound: transition non-primary Invalid IPs to Deleting when pod is released.
  • Tests: add cases for in-use missing IPs marked Invalid and primary IP preservation.

^{Written by Cursor Bugbot for commit 5465d9e. This will update automatically on new commits. Configure here.}

[cursor]

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 21

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bug: Invalid IPs assigned in takeover case

The takeover logic assigns IPs to pods without checking the IP status. This allows pods to be assigned IPs with IPStatusInvalid or IPStatusDeleting status, which could be non-functional or in the process of being removed. The normal assignment flow at lines 722 and 767 correctly filters for IPStatusValid, but the takeover case at lines 676-680 and 689-693 lacks this validation, creating an inconsistency that could assign invalid IPs to pods.

pkg/controller/multi-ip/node/pool.go#L675-L680

terway/pkg/controller/multi-ip/node/pool.go

Lines 675 to 680 in 5465d9e

	eniIP, ok := ipv4Map[info.IPv4]
	if ok && (eniIP.IP.PodID == "" || eniIP.IP.PodID == podID) {
	info.ipv4Ref = eniIP
	eniIP.IP.PodID = podID
	eniIP.IP.PodUID = info.PodUID
	log.Info("assign ip (from pod status)", "pod", podID, "ip", eniIP.IP, "eni", eniIP.NetworkInterface.ID)

pkg/controller/multi-ip/node/pool.go#L688-L693

terway/pkg/controller/multi-ip/node/pool.go

Lines 688 to 693 in 5465d9e

	eniIP, ok := ipv6Map[info.IPv6]
	if ok && (eniIP.IP.PodID == "" || eniIP.IP.PodID == podID) {
	info.ipv6Ref = eniIP
	eniIP.IP.PodID = podID
	eniIP.IP.PodUID = info.PodUID
	log.Info("assign ip (from pod status)", "pod", podID, "ip", eniIP.IP, "eni", eniIP.NetworkInterface.ID)

 

---

[codecov]

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.77%. Comparing base (fe8cdd8) to head (5465d9e).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/controller/multi-ip/node/pool.go	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #942      +/-   ##
==========================================
+ Coverage   61.76%   61.77%   +0.01%     
==========================================
  Files         131      131              
  Lines       16096    16106      +10     
==========================================
+ Hits         9942     9950       +8     
- Misses       4980     4983       +3     
+ Partials     1174     1173       -1     

Flag	Coverage Δ
unittests	61.77% <83.33%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.