Skip to content

feat: swap tab and btab direction when tmux-popup shows above the cursor#326

Merged
Aloxaf merged 1 commit intoAloxaf:masterfrom
zyf0330:master
Nov 24, 2022
Merged

feat: swap tab and btab direction when tmux-popup shows above the cursor#326
Aloxaf merged 1 commit intoAloxaf:masterfrom
zyf0330:master

Conversation

@zyf0330
Copy link
Copy Markdown
Contributor

@zyf0330 zyf0330 commented Nov 7, 2022

Do you think this is a good change?

@Aloxaf
Copy link
Copy Markdown
Owner

Aloxaf commented Nov 24, 2022

Quite reasonable.

@Aloxaf Aloxaf merged commit 39159fe into Aloxaf:master Nov 24, 2022
@tardypad
Copy link
Copy Markdown

tardypad commented Dec 7, 2022

I think this commit should be reverted because it doesn't follow the usual behavior of fzf.
fzf doesn't invert the meaning of up and down actions depending on the layout.
So this brings inconsistencies in the usage of fzf.
For example when used in fzf-tab with a default layout (in this tmux popup over the cursor), tab goes up visually but in other instances, it would naturally go down.

Personnally this change broke the usage of fzf-tab because I force fzf to use reverse layout by default.

As a workaround I was trying to find a way via the options to overwrite this change but I couldn't find anything

@Aloxaf
Copy link
Copy Markdown
Owner

Aloxaf commented Dec 8, 2022

@tardypad
Thanks for your advice. I add a option named popup-smart-tab to control this behavior.
You can use zstyle ':fzf-tab:complete:*' popup-smart-tab false to disable it now.

@tardypad
Copy link
Copy Markdown

tardypad commented Dec 9, 2022

@Aloxaf Thanks for the really quick change.
I can live with this workaround :)

tardypad added a commit to tardypad/dotfiles that referenced this pull request Jan 4, 2023
No inversion of tab press behavior when the tmux popup is displayed
above the prompt.
See Aloxaf/fzf-tab#326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants