feat(fit-preview): optionally double comp_length when showing preview#445
Open
jimeh wants to merge 1 commit intoAloxaf:masterfrom
Open
feat(fit-preview): optionally double comp_length when showing preview#445jimeh wants to merge 1 commit intoAloxaf:masterfrom
jimeh wants to merge 1 commit intoAloxaf:masterfrom
Conversation
When previews are enabled, they typically take up half the width of the popup. This adds an option to make it double the width when preview is enabled, hence ensuring that the full text of completion items are visible.
|
@Aloxaf ping. Currently |
|
Very cool. This solves my main gripe with fzf-tab. But I wonder, would it be difficult to trigger resizing the popup pane when toggling the preview? I use fzf-tab-source for rich preview windows, but they're more something you want to toggle on when needed rather than having them always on. Meaning the pane will always be double its necessary width, just for the off chance the preview is toggled on. |
|
Very crude POC |
Sneethe
reviewed
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This was a 5 minute hack just to see if I could fix it, so more than happy to hear any feedback and change things as needed :)
When previews are enabled, they typically take up half the width of the popup. This adds an option to make it double the width when preview is enabled, hence ensuring that the full text of completion items are visible.
Screenshots
Before
With preview:
Without preview:
After
With preview:
Without preview: