Skip to content

feat: allow command timeouts in config#40

Open
OfriHarlev wants to merge 1 commit intoAmElmo:mainfrom
OfriHarlev:upstream/configurable-timeouts
Open

feat: allow command timeouts in config#40
OfriHarlev wants to merge 1 commit intoAmElmo:mainfrom
OfriHarlev:upstream/configurable-timeouts

Conversation

@OfriHarlev
Copy link
Copy Markdown
Contributor

Summary

  • add a nested timeouts config section to proofshot.config.json
  • make browser open, recording, exec passthrough, screenshot, and video trim timeouts configurable
  • add focused tests for nested timeout config merging
  • document the timeout configuration in the user-facing docs

Problem

ProofShot currently hardcodes several operational timeouts.

That works well in fast local environments, but it makes slower projects and CI-like setups harder to support without source patches.

Solution

This change adds a project-level timeouts section so browser open, recording, screenshot, exec passthrough, and video trim behavior can be tuned without modifying ProofShot source.

Testing

  • npm test
  • npm run build

@OfriHarlev OfriHarlev force-pushed the upstream/configurable-timeouts branch 2 times, most recently from 807e263 to 27c0cfe Compare April 9, 2026 00:25
@AmElmo AmElmo self-assigned this Apr 13, 2026
@OfriHarlev OfriHarlev force-pushed the upstream/configurable-timeouts branch from 27c0cfe to 2067de4 Compare April 13, 2026 15:58
@OfriHarlev
Copy link
Copy Markdown
Contributor Author

@AmElmo I rebased this PR with latest main

@OfriHarlev OfriHarlev force-pushed the upstream/configurable-timeouts branch from 2067de4 to 8c55973 Compare April 14, 2026 08:22
@OfriHarlev
Copy link
Copy Markdown
Contributor Author

@AmElmo any chance this can get a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants