Open
Conversation
807e263 to
27c0cfe
Compare
27c0cfe to
2067de4
Compare
Contributor
Author
|
@AmElmo I rebased this PR with latest main |
2067de4 to
8c55973
Compare
Contributor
Author
|
@AmElmo any chance this can get a review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeoutsconfig section toproofshot.config.jsonProblem
ProofShot currently hardcodes several operational timeouts.
That works well in fast local environments, but it makes slower projects and CI-like setups harder to support without source patches.
Solution
This change adds a project-level
timeoutssection so browser open, recording, screenshot, exec passthrough, and video trim behavior can be tuned without modifying ProofShot source.Testing
npm testnpm run build