Update OpenSSL, variable renaming, formatting, enforce CA #263
Conversation
ospfranco
changed the title
| // | ||
|
|
||
| import Foundation | ||
| import OSLog |
There was a problem hiding this comment.
Here formatting changes make everything hard to read :S I'm sorry. Let me know if this is still ok to review/merge
There was a problem hiding this comment.
Hi, could you undo the formatting please?
I'll manually include the updates to OpenSSL-Package and updates for CocoaPods (not the bump to latest as that requires more testing) but won't include the other code changes in this release (just lack of time) but once the PR is updated then I'll take a look.
I've already added custom AA (as per previous release) and that will be going up too
There was a problem hiding this comment.
I'm trying to match the old formatting style via swift-format but it seems paranthesis spaces and other weird character spacing is not part of the official spec. Which tool are you using to format the code?
There was a problem hiding this comment.
Looking more carefully maybe you are not using a formatter? There are small random spaces in a few spots here and there?
There was a problem hiding this comment.
I tried reducing my changes to the minimum but at this point no formatter can replicate the style that was there before. Let me know if you can review the code in this format. Basically at this point besides the code formatting the only other change is the enforceCA flag that forces chip authentication to prevent replay attacks. Though I would strongly encourage the use of a formatter.
There was a problem hiding this comment.
If you are using xcode you can set up auto format on save. It's not the most straightforward process but better than nothing
https://medium.com/@jozott/format-on-save-xcode-swift-8133d049b3ac
or set up some git hooks to run auto format on commit
ospfranco
changed the title
ospfranco
force-pushed
the
contributions
branch
3 times, most recently
from
9f5f610 to
e2b1241
Compare
ospfranco
force-pushed
the
contributions
branch
from
fdf5d6a to
5a5d844
Compare
Update package Update readme Update to latest OpenSSL version, accept aa challenge and change name Fix missing passing aaChallenge Clean up code, correct typo and move logger calls to PassportReader.swift Remove DS_Store restore podspec name Add option to enforce CA check Revive cocoapods app Revert team change and other xcode changes Try to match previous formatting Reset unrelated files Restore readme Try different formatting format format format Fix typos Get rid of duplicated property One more try at undo formatting Restore old formatting Typos chip authentication
ospfranco
force-pushed
the
contributions
branch
from
ce1b58d to
312fe76
Compare
2 participants
Uh oh!
There was an error while loading. Please reload this page.