Draft
Conversation
alexytomi
force-pushed
the
feat/cinnabar_fixes
branch
2 times, most recently
from
e9a5384 to
f059607
Compare
Jars/Modules and AAR are from https://github.com/AngelAuraMC/lwjgl3/actions/runs/23080032954 This is for Cinnabar mod, which is in anticipation of vanilla moving over to vulkan
We get a `InvalidModuleDescriptorException` due to our fat glfw jar providing tinyfd classes despite not being declared properly in module-info.class, this then confuses the loader as it tries to load another different tinyfd jar file with a proper module-info.class. To avoid this, let's just remove tinyfd. Any mod using it would likely just ship with it.
alexytomi
force-pushed
the
feat/cinnabar_fixes
branch
from
f059607 to
75054ef
Compare
TODO: Turn patching into a completely seperate project, that patches modules one by one. This is needed to work with how module encapsulation works in Java 9+. We will need to move over all the changes from the lwjgl repository into our patcher so we can simply fetch LWJGL from maven. This will be more integrated with the project while letting us modify LWJGL easily.
Cinnabar needs this. Forgot to add it. Uses https://github.com/AngelAuraMC/lwjgl3/actions/runs/23288758115 AngelAuraMC/lwjgl3@1c37ec7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Mojang is swapping over to vulkan due to vibrant visuals. Cinnabar is the closest thing to this, so we will be using it to anticipate the official mojang changes.
Changes
Note
Please merge #203 before this as this builds off that PR.