Cherry-pick change from astcenc 4.1.0 (#623)#3
Merged
AnonN10 merged 1 commit intoAnonN10:masterfrom Aug 19, 2022
Merged
Conversation
Without the fix SSE2 and SSE4.1 builds that use the decompressor APIs can generate faults on masked stores, as _mm_maskmoveu_si128() doesn't suppress faults on any lanes that are disabled. AVX2 builds are not impacted by this - the AVX2 masked store does suppress faults on masked lanes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the fix SSE2 and SSE4.1 builds that use the decompressor APIs can generate faults on masked stores, as _mm_maskmoveu_si128() doesn't suppress faults on any lanes that are disabled. AVX2 builds are not impacted by this - the AVX2 masked store does suppress faults on masked lanes.