Reimplement CancellationTokenSourcePool#1192
Merged
Merged
Conversation
martincostello
approved these changes
May 17, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1192 +/- ##
==========================================
+ Coverage 83.39% 83.44% +0.05%
==========================================
Files 273 275 +2
Lines 6316 6336 +20
Branches 1027 1031 +4
==========================================
+ Hits 5267 5287 +20
Misses 844 844
Partials 205 205
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
This PR changes the way the
CancellationTokenSourcePoolworks to allign better with the .NET 8TimeProvider.Unblock further work on #1144
Confirm the following