Use the same analyzers for V7 projects#1287
Merged
Conversation
Member
|
I did have a play around with this locally for #1272 but it didn't seem to make any difference - maybe I just did something wrong 😄 Will take a proper look at the PR later this afternoon 👍 |
Codecov Report
@@ Coverage Diff @@
## main #1287 +/- ##
=======================================
Coverage 83.25% 83.26%
=======================================
Files 263 263
Lines 6290 6291 +1
Branches 993 993
=======================================
+ Hits 5237 5238 +1
Misses 844 844
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martincostello
added
CI/build
v8
martincostello
approved these changes
Jun 13, 2023
Member
martincostello
left a comment
martincostello
left a comment
There was a problem hiding this comment.
A few minor comments, but otherwise some nice tidying-up. Thanks!
src/Polly.Core.Tests/Hedging/Controller/HedgingExecutionContextTests.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+10
to
+13
| <UseDefaultAnalyzers>true</UseDefaultAnalyzers> | ||
| <NoWarn>$(NoWarn);S103;S104;CA2000;IDE0011;SA1600;SA1204;SA1602;S6608;IDE1006;CA2008;CA1806;CA2201;</NoWarn> | ||
| <NoWarn>$(NoWarn);SA1414;CA1508;S3878;CA1030;S4144;S3717;SA1129;SA1407;S1402;SA1649;SA1402;S4056;CA1031</NoWarn> | ||
| <NoWarn>$(NoWarn);S2184;</NoWarn> |
Comment on lines
+10
to
+15
| <NoWarn>$(NoWarn);IDE0011;SA1501;S103;IDE0055;SA1111;IDE0066;S3872;SA1127;SA1128;SA1402;SA1513;SA1414;S3215;S2955</NoWarn> | ||
| <NoWarn>$(NoWarn);IDE0044;IDE1006;CA1062;S107;CA1068;S4039;SA1121;CA1000;CA1063;SA1113;CA1031;CA1051;CA1200</NoWarn> | ||
| <NoWarn>$(NoWarn);SA1629;SA1612;CA2211;S2223;CA1032;CA1815;CA1816;S4457;SA1615;IDE0250;S109;SA1618;SA1407;CA1033</NoWarn> | ||
| <NoWarn>$(NoWarn);SA1515;S4023;CA1010;IDE0063;S2681;S3442;S3880;CA1064;SA1110;SA1203;SA1649;SA1625;SA1623;SA1118</NoWarn> | ||
| <NoWarn>$(NoWarn);S3253;S3971;S6605;CA1724;CA1716;SA1108;CA1710;S4049;S3246;SA1204;S3928;CA1508;CA1822;CA2201;SA1642</NoWarn> | ||
| <NoWarn>$(NoWarn);SA1805;SA1129;SA1805;CA1805;CA1821</NoWarn> |
Member
There was a problem hiding this comment.
Maybe we can make an issue to track turning some of these back on?
Contributor
Author
There was a problem hiding this comment.
Will do post merge.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
I have noticed the duplicate .
editorconfigfile that could be cause of #1272.I got rid of it so all projects now use the default set of analyzers. The side effect is that the is now a LOT of issues in
Pollyproject which I had to suppress (except a few low-risk, low effort fiixes).For
Polly.SpecsI was a lot more benevolent and let VS do some cleanup.Confirm the following