Skip to content

Add new metering tests to cover uncovered lines#1474

Merged
martintmk merged 1 commit into
mainfrom
mtomka/add-metering-tests
Aug 10, 2023
Merged

Add new metering tests to cover uncovered lines#1474
martintmk merged 1 commit into
mainfrom
mtomka/add-metering-tests

Conversation

@martintmk
Copy link
Copy Markdown
Contributor

@martintmk martintmk commented Aug 10, 2023

Details on the issue fix or feature implementation

Noticed this in #1144.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label Aug 10, 2023
@martintmk martintmk added this to the v8.0.0 milestone Aug 10, 2023
@martincostello
Copy link
Copy Markdown
Member

Would this maybe explain that random 99.75% coverage failure we get sometimes? Or is this something entirely new/different?

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 10, 2023

Codecov Report

Merging #1474 (9debfbf) into main (855ce01) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1474   +/-   ##
=======================================
  Coverage   83.88%   83.88%           
=======================================
  Files         275      275           
  Lines        6492     6492           
  Branches     1015     1015           
=======================================
  Hits         5446     5446           
  Misses        837      837           
  Partials      209      209           
Flag Coverage Δ
linux ?
macos 83.88% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@martintmk
Copy link
Copy Markdown
Contributor Author

Would this maybe explain that random 99.75% coverage failure we get sometimes? Or is this something entirely new/different?

It was revealed on .NET 8 so it's possible that this affected also .NET 7 and lower. Anyway let's see, this change can only help.

@martintmk martintmk enabled auto-merge (squash) August 10, 2023 07:58
@martintmk martintmk merged commit c8e0366 into main Aug 10, 2023
@martintmk martintmk deleted the mtomka/add-metering-tests branch August 10, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v8 Issues related to the new version 8 of the Polly library.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants