Simmy API review Part 2 - Prefer Chaos over Monkey

[peter-csala]

Pull Request

The issue or feature being addressed

• Simmy API Review and Feedback #1901
• Simmy API review Part 1 #1909

Details on the issue fix or feature implementation

• Renamed the base classes
  • MonkeyStrategy >> ChaosStrategy
  • MonkeyStrategyOptions >> ChaosStrategyOptions
• Renamed Behavior classes
  • BehaviorChaosStrategy to ChaosBehaviorStrategy
  • BehaviorStrategyOptions >> ChaosBehaviorStrategyOptions
  • BehaviorConstants >> ChaosBehaviorConstants
  • BehaviorPipelineBuilderExtensions >> ChaosBehaviorPipelineBuilderExtensions
• Renamed Fault classes
  • FaultChaosStrategy to ChaosFaultStrategy
  • FaultStrategyOptions >> ChaosFaultStrategyOptions
  • FaultConstants >> ChaosFaultConstants
  • FaultPipelineBuilderExtensions >> ChaosFaultPipelineBuilderExtensions
• Renamed Latency classes
  • LatencyChaosStrategy to ChaosLatencyStrategy
  • LatencyStrategyOptions >> ChaosLatencyStrategyOptions
  • LatencyConstants >> ChaosLatencyConstants
  • LatencyPipelineBuilderExtensions >> ChaosLatencyPipelineBuilderExtensions
  • Renamed Outcome classes
  • OutcomeChaosStrategy to ChaosOutcomeStrategy
  • OutcomeStrategyOptions >> ChaosOutcomeStrategyOptions
  • OutcomeConstants >> ChaosOutcomeConstants
  • OutcomePipelineBuilderExtensions >> ChaosOutcomePipelineBuilderExtensions
• Renamed AddChaosResult to AddChaosOutcome
• Updated related docs as well

Extra

• Replaced behaviour spelling to behavior in ChaosBehaviorStrategyTests
• Moved userDelegateExecuted and onXYZInjectedExecuted method variables to class level in several test classes

Confirm the following

• I started this PR by branching from the head of the default branch
• I have targeted the PR to merge into the default branch
• I have included unit tests for the issue/feature
• I have successfully run a local build

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24a86c8) 84.80% compared to head (03edbf1) 84.80%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1913   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files         312      312           
  Lines        6897     6897           
  Branches     1056     1056           
=======================================
  Hits         5849     5849           
  Misses        839      839           
  Partials      209      209           

Flag	Coverage Δ
linux	84.80% <100.00%> (ø)
macos	?
windows	84.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[peter-csala]

After applying the renaming suggestions by @martintmk we have some inconsistency:

• BehaviorChaosStrategy : ChaosStrategy
• ChaosBehaviorStrategyOptions : ChaosStrategyOptions

Option A: Rename BehaviorChaosStrategy to ChaosBehaviorStrategy
Option B: Rename ChaosBehaviorStrategyOptions to BehaviorChaosStrategyOptions

Which one do we prefer? @martincostello, @martintmk

I would vote to Option A because that would align better with the AddChaosBehavior.

[martincostello]

I also prefer option A.

[martintmk]

Looks fine, great job!

[martintmk]

@martincostello Is this ok to merge?