Skip to content

Fix baseline script if no nullable header#2554

Merged
martincostello merged 1 commit intomainfrom
fix-script-bug
Mar 18, 2025
Merged

Fix baseline script if no nullable header#2554
martincostello merged 1 commit intomainfrom
fix-script-bug

Conversation

@martincostello
Copy link
Copy Markdown
Member

Fix baseline files not being cleared if the #nullable header is not present in the Unshipped file.

Found in domaindrivendev/Swashbuckle.AspNetCore#3317 when I copied the script to use there.

This use case doesn't affect us, but it's good to make it Technically Correct™️.

Fix baseline files not being cleared if the nullable header is not present in the file.
@martincostello martincostello enabled auto-merge (rebase) March 18, 2025 17:16
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (1b7defa) to head (3cd350f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2554   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         311      311           
  Lines        7327     7327           
  Branches     1013     1013           
=======================================
  Hits         7051     7051           
  Misses        222      222           
  Partials       54       54           
Flag Coverage Δ
linux 96.23% <ø> (ø)
macos 96.23% <ø> (ø)
windows 96.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martincostello martincostello merged commit da315ba into main Mar 18, 2025
26 checks passed
@martincostello martincostello deleted the fix-script-bug branch March 18, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant