Fix animation export logic and add support for dumping animations via mdlconvert #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Cubic Hermite Spline implementation
…at the non-skinning "reference joints" remain as joints when importing into Blender
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the animation export process so that it will correctly interpolate animation values when the keyframes of the different components of a property don't line up (e.g. there is a keyframe for "Position.X" but not "Position.Y" or "Position.Z", and keyframes need to be synthesized for Y/Z).
This PR also changes how empty/non-skinning joints are handled, ensuring that they are preserved as actual armature bones when imported into tools like Blender instead of plain empty objects.
Finally, mdlconvert was updated to include options for dumping animations during model export, taking advantage of the newly-fixed animation export system.