-
Notifications
You must be signed in to change notification settings - Fork 17
Add missing firmware types and dev versions #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add missing firmware types and dev versions #16
Conversation
d816eb7 to
708dd0a
Compare
|
If we're including development versions, should we stop bothering to process the beta versions? There should always be a corresponding minor that's either stable or dev, unless there's a beta released during a skipped minor (e.g. if Alternatively, maybe it makes sense to keep betas in a non-versioned folder (e.g. just If need be I can update the sort order to properly handle considerations like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The last commit (708dd0a) says Blimp but it changes AP_Peripherals.
- 580b8f7 has as title: "scripts: run_parsers: include development versions" but it's creating a tag in the repository.
- The first commit is doing multiple changes at once, can you brean in multiple commits ?
- It's adding Tracker, Blimp, AP_Periph
- It's change the logic of get_version_for_tag
- It's adding staticmethod
- Moving Groundskeeper to self
5b409fe to
d9d792c
Compare
I've updated the commit message to better reflect what it does.
It's creating a temporary local tag so that the latest changes get included in the normal tag handling. I've added some code commentary to better describe what it's doing.
Done. I also added an improvement to how the initial patch handling gets printed, and did a back-fill generation for 4.6 because there were apparently some changes to the parameters since our last generation of it. |
patrickelectric
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for generating the files in this PR over having the CI generating it ?
|
I suppose the “latest” ones could be done by CI - I just generated them to make sure it was working properly. The back-fill ones are necessary because Groundskeeper assumes generations are complete up to the date of the latest repo commit (even if it’s actually a code change), so any tags from before that commit won’t get automatically generated/updated metadata. We’ve already had some code commits merged in this repo since the last ArduPilot tags, so they now require manual generation. |
d9d792c to
cae6f17
Compare
|
I removed the non-required "latest" generations (since CI should do them), and moved the old back-fill one to just after the code cleanup commits :-) |
Makes it easier to follow, and see which patch will be processed for a given minor release.
cae6f17 to
9608d08
Compare
|
Improved some commit message explanations, and fixed a slightly incorrect code comment. |
Required because repo merged code changes between the last metadata generation occurring and the relevant ArduPilot tags being made, so the current tags are being ignored by Groundskeeper.
Co-Authored by: ES-Alexander <[email protected]>
Required because the tags are older than the latest repo commit, so Groundskeeper will ignore them.
Treats the latest ArduPilot code state as a temporary new version, so we have metadata generated for the master branch (if it is configured as a newer major or minor than the existing releases). Co-authored-by: ES-Alexander <[email protected]>
9608d08 to
13e2927
Compare
Closes #12 + closes #13 by replacement, rebasing over
mainand factoring in relevant feedback (plus a couple of other fixes determined while testing). Includes initial output generations for both, plus a general generation back to the latest generation date (which updates Sub-4.5).@patrickelectric reviewing is likely easiest by commit rather than by final file state(s).