AP_Logger: added build directory to VER message#25239
Merged
tridge merged 1 commit intoArduPilot:masterfrom Oct 13, 2023
Merged
AP_Logger: added build directory to VER message#25239tridge merged 1 commit intoArduPilot:masterfrom
tridge merged 1 commit intoArduPilot:masterfrom
Conversation
peterbarker
approved these changes
Oct 12, 2023
Contributor
peterbarker
left a comment
peterbarker
left a comment
There was a problem hiding this comment.
I like this. LGTM apart from the missing documentation for this new field.
Thankfully there are automated processes that will whinge about that so I don't need to :-)
Contributor
Author
|
@peterbarker I think we are missing LoggerMessage for VER completely, or at least I can't find it |
IamPete1
reviewed
Oct 12, 2023
this allows log review tools to use right parameter and mode map when vendor has changed the vehicle type strings
tridge
force-pushed
the
pr-build-type-ver
branch
from
79a4efe to
3200297
Compare
IamPete1
approved these changes
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this allows log review tools to use right parameter and mode map when vendor has changed the vehicle type strings
goes with this pymavlink change for MAVExplorer: ArduPilot/pymavlink#865