Saving send_callback after the use of auto_mavlink_version#1042
Merged
peterbarker merged 1 commit intoArduPilot:masterfrom May 23, 2025
Merged
Saving send_callback after the use of auto_mavlink_version#1042peterbarker merged 1 commit intoArduPilot:masterfrom
peterbarker merged 1 commit intoArduPilot:masterfrom
Conversation
In the function auto_mavlink_version, the save of the mav.callback was here, but not the one related to the mav.send_callback, so I added it.
Contributor
|
What problem does this fix? |
Contributor
Author
|
I tried to set a callback and a send_callback before receiving any MAVLink message from the master, but when I received one, auto_mavlink_version was called and only my send_callback was erased. So I think it makes sense to add this |
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the function auto_mavlink_version, the save of the mav.callback was here, but not the one related to the mav.send_callback, so I added it.