Merged
Conversation
Contributor
|
Nice, I think you can speed up things even more by using some github caching. Not blocking comments, we can add this on a second step |
tridge
approved these changes
May 30, 2025
Contributor
|
@robertlong13 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brought the time from 30m to 8m, which I think we can live with. Also added Linux ARM, Windows, and Mac (x86, ARM, and universal). Funny enough, the bottleneck is still Linux x86. The Linux builds use docker, and the musl 32-bit wheel takes most of the time.
I've set it so that it only builds everything on push to master or release. PRs get only a fraction of the full build, and take about 3 minutes instead of 8. On PRs, I build Linux and Windows, 64-bit only, and for only 3.8 and 3.13 (which I deemed most likely to accidentally break in a PR). I could honestly leave all the python versions and all the OS and just disable 32-bit and it'd likely still be about 3 minutes, but I think I'll keep it the way I have it. We're still building everything after we merge, so we should be quick to catch any regressions. I also added the ability to manually trigger a run in case you see a PR that you think is risky enough to try a full build before merging.
The only wheels we're missing now are Windows ARM, because the Windows ARM runner doesn't come with enough stuff to compile lxml and lxml doesn't supply wheels WinARM. I'll just wait until lxml adds wheels for that, much to the dismay of all 0 people asking me for Windows ARM wheels.
I added concurrency rules so that subsequent PR pushes, or even rapid merging of several PRs, don't bog down CI.
Tested everything pretty thoroughly on my fork before opening.