WLua: Only truncate hex dump lines for test case output checks#1052
Merged
tridge merged 1 commit intoArduPilot:masterfrom Jul 14, 2025
Merged
WLua: Only truncate hex dump lines for test case output checks#1052tridge merged 1 commit intoArduPilot:masterfrom
tridge merged 1 commit intoArduPilot:masterfrom
Conversation
tridge
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the Wireshark LUA test cases truncate all lines at 72 characters because the tshark output for byte-stream lines gets truncated with a '...' at one point.
This change alters the logic so that only byte-stream lines are truncated, rather than all lines.
Byte-steam lines are recognised by matching a regular expression of at least 60-consecutive [0-9a-z] characters.
This ensures that relevant parts of the test output are not lost. For example:
This becomes even more relevant for a test case I plan to add for 64-bit bitfields in an upcoming PR fix for issue #895.
Tested via local running of pytest and CI.