Merged
Conversation
This file is for build depenencies only. lxml is only needed at runtime. Removing this dependency makes our build CI simpler and more reliable.
"auto" on linux no longer includes 32-bit builds, and they are considering doing the same for Windows in the future. Added 32-bit builds explicitly for both
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two fixes:
Remove "lxml" from pyproject.toml
This is necessary to fix a recent build failure. lxml just released a new version 6.0.0, which does not have a wheel for cp38-manylinux_aarch64, where the previous version did. The thing is, there's really no reason for us to need to pip install lxml into the isolated build environment; it's a runtime dependency only.
pyproject.tomldoes not need this in there.This also lets me build the windows-arm wheels now (surely few, if any, care about that yet).
I'm pretty sure it doesn't need "future" in there either, but I didn't bother removing that as it isn't hurting anything like the lxml thing is.
Update cibuildwheel to 3.0.0
Split out from #1072
I went through the change log and it looks like the only change that impacts us was that they dropped 32-bit linux from the "auto" group. I have changed that to "auto64 auto32". They mentioned that they are considering doing the same to windows in the future, so I added that to the windows line too to cover us when that happens.
I have tested the build on my fork, using workflow-dispatch to make sure all archs/versions build