mavutil: Do not use unknown messages to calculate number of lost packets#891
Merged
tridge merged 1 commit intoArduPilot:masterfrom Dec 20, 2023
Merged
Conversation
Contributor
|
Just to clarify what @joshanne said:
With this change, the number of lost messages will increment by |
tridge
approved these changes
Dec 20, 2023
Contributor
|
good find, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this one when adding a custom mavlink message.
The decoding of the packet affects the mav_loss calculation because the unknown message does not have its header populated.
To a user, this could appear as though the vehicle radio link is intermittent/bad.