Mavgen WLua: Updates to displayed field values in Wireshark#896
Merged
peterbarker merged 1 commit intoArduPilot:masterfrom Dec 27, 2023
Merged
Conversation
Use lookup table to convert degE7, rad, rad/s units for display Values are appended to display - raw value is not overwritten Show value of bitmask fields in HEX_DEC format Even when no enum is linked (as for TERRAIN_REQUEST.mask) Including for the compatibility flags in message header Pad bitfields to a multiple of 4 to match hex Append readable date/time to time_usec fields if it represents a unix time Otherwise display time in seconds, unless its < 1s In header, show system id as DEC, and MAV_COMPONENT as enum Decode command parameters on MISSION_ITEM messages Correct field name and datatype for x,y,z on MISSION and COMMAND INT messages Add test cases to show unit decoding and MISSION_ITEM_INT fields Fix spurious ENUM_END lines showing up in the disection
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow up to #856, this PR proposes some updates to the decoding and displaying of Mavlink fields in Wireshark:
- Convert some units into more readable values (appended to the original, so raw value is still shown), e.g.:
More converted units can be added, by adding to the unit_decoder_mapping lookup table.
- Show value of bitmask fields in HEX_DEC format, and pad bitfields to a multiple of 4 to match hex, e.g.:
- Append local date/time to μs fields if it represents a unix time, or display time in seconds, unless < 1s, e.g.:
- In header, show system id as DEC, and MAV_COMPONENT as enum, e.g.:
- Decode command parameters on MISSION_ITEM messages, e.g.:
Previously this was only done for COMMAND_LONG/INT messages, but not for MISSION_ITEM(_INT) messages.
- Added 2 new automated test cases to demonstrate/check the unit decoding and MISSION_ITEM_INT fields.