Tools: fix mlog attribute in mavplayback#917
Merged
peterbarker merged 1 commit intoArduPilot:masterfrom Feb 6, 2024
Merged
Conversation
peterbarker
approved these changes
Feb 6, 2024
Contributor
peterbarker
left a comment
peterbarker
left a comment
There was a problem hiding this comment.
Usually we'd prefix the commit message (as well as the PR title) with the directory, but we're not really strict in pymavlink.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, rewind & forward buttons as well as dragging across the timeline don't work and produce an error:
Exception in Tkinter callback Traceback (most recent call last): File "/usr/lib64/python3.11/tkinter/__init__.py", line 1948, in __call__ return self.func(*args) ^^^^^^^^^^^^^^^^ File "/home/szymon/development/opensource/forks/pymavlink/tools/mavplayback.py", line 136, in forward self.mlog.filehandle.seek(pos) ^^^^^^^^^^^^^^^^^^^^ AttributeError: 'mavmmaplog' object has no attribute 'filehandle'Some of the calls were changed from mlog.filehandle to mlog.f by @tridge in #890, it seems to me that the remaining have to be changed as well.