Merged
Conversation
3.5 was EOL in 2020, and doesn't support fastcrc
peterbarker
approved these changes
Apr 27, 2024
Contributor
peterbarker
left a comment
peterbarker
left a comment
There was a problem hiding this comment.
A lot of ancient code being duplicated, so we're adding sub-optimal stuff in.... but at least it's well-tested sub-optimal stuff.
|
|
||
| def accumulate(self, buf): | ||
| """add in some more bytes (it also accepts strings)""" | ||
| if sys.version_info[0] == 2: |
Contributor
There was a problem hiding this comment.
Should we really be adding Py2 compat here?
| buf = bytearray(buf.encode()) | ||
| elif type(buf) is str: | ||
| buf = bytes(buf.encode()) | ||
| elif type(buf) is list: |
Contributor
There was a problem hiding this comment.
Should all of these be isinstance?
for performance testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fastcrc runs about 3x faster than existing x25 crc