Fixing two issues#39
Open
kibaekkim wants to merge 16 commits intoArgonne-National-Laboratory:masterfrom
Open
Conversation
…ered matrix inputs
…ginal code for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have found and fixed two issues.
The first issue is that member variable
xDiagis not initialized and can potentially be undefined ifnxlow + nxupp == 0(that is, all variables are unbounded). This has been fixed in filessLinsysRoot.*. The initialization is safe becausexDiagwill be overwritten ifnxlow + nxupp > 0. Please, however, make sure thatxDiagis initialized with the right data.The second issue is the assumption in the code that the matrix inputs are always column-ordered. This has been fixed in file
sTreeImpl.C.