Conversation
797ce6d to
c100ad7
Compare
c100ad7 to
185a145
Compare
185a145 to
d4d54f6
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| type-check: | ||
| name: Type Check | ||
| name: Type Check Python |
There was a problem hiding this comment.
Type-check job missing phoenix_client trigger condition
Medium Severity
The deleted type-check-integration-tests job had the condition needs.changes.outputs.phoenix == 'true' || needs.changes.outputs.phoenix_client == 'true', meaning it ran type checking when only packages/phoenix-client/ files changed. The consolidated type-check job only triggers on needs.changes.outputs.phoenix == 'true', which doesn't cover packages/phoenix-client/** changes. This silently skips type checking of integration tests (which import from phoenix-client) when only client code changes.


Note
Medium Risk
CI and local developer workflows for dependency sync and type checking change meaningfully, and mypy’s scope now explicitly includes
tests/, which could surface new failures or behavior differences in type-check gating.Overview
Python type checking is reworked to run
mypyviauv. CI’stype-checkjob now doesuv sync --frozenanduv run mypy(and expands sparse-checkout to includesrc/,packages/, andtests/), replacing the prior tox-driven type-check jobs for main code, unit tests, and integration tests.Tooling/docs are updated to match the new workflow. The Makefile’s
typecheck-pythontarget runsuv run mypy, tox envs fortype_check*plusadd_symlinks/remove_symlinksare removed, and docs (DEVELOPMENT.md,CONTRIBUTING.md,AGENTS.md, Cursor rule) now point tomake typecheck-python/uv run mypy.Mypy configuration and small typing fixes.
pyproject.tomladdsfiles = ["src/", "tests/"], addstypes-PyYAML, and several code/test tweaks address typing issues (e.g., wrap Google GenAI async client factories with@asynccontextmanager, avoid setting span attributes withNonetoken counts, and remove a few unnecessarycast/ignore annotations).Written by Cursor Bugbot for commit c739cee. This will update automatically on new commits. Configure here.