chore: standardize TypeScript versions across the repo#11587
Merged
cephalization merged 3 commits intomainfrom Feb 19, 2026
Merged
chore: standardize TypeScript versions across the repo#11587cephalization merged 3 commits intomainfrom
cephalization merged 3 commits intomainfrom
Conversation
dosubot
bot
added
the
size:L
@arizeai/phoenix-cli
@arizeai/phoenix-client
@arizeai/phoenix-evals
@arizeai/phoenix-mcp
@arizeai/phoenix-otel
commit: |
axiomofjoy
approved these changes
Feb 19, 2026
Provides a framework for TypeScript tooling migrations including: - Tool replacements (ESLint → oxlint, Prettier → oxfmt) - Major version upgrades (TypeScript, React, Vite) - Dependency upgrades with breaking changes Covers: - Monorepo structure and sync requirements - 12-phase migration workflow - Config inheritance patterns - Pre-commit hook setup - Documentation update checklist - Version sync CI checks - Troubleshooting common issues
Align all packages on TypeScript 5.9.3 and hoist the dependency to workspace roots to prevent version drift. Changes: - Upgrade app/ from TypeScript ~5.4.5 to ^5.9.3 - Remove per-package TypeScript declarations from js/packages/* and js/examples/* (they now inherit from js/ workspace root) - Add TypeScript version consistency check to CI workflow - Fix type errors from stricter TypeScript 5.5+ checks: - Add @ts-expect-error for soon-to-be-deleted pointcloud code - Remove obsolete @ts-expect-error for startViewTransition (now typed) - Add typeof narrowing for react-aria Key types Closes #11565
Rename type:check to typecheck for consistency with app/ and common conventions (Next.js, Vite, etc.). Changes: - Rename js/ root script from type:check to typecheck - Rename type:check to typecheck in phoenix-client, phoenix-config, phoenix-evals, and phoenix-otel packages - Update typescript-packages-CI.yml to use new script name - Update typescript-tooling-migration skill documentation - Mark TypeScript as CI-enforced in skill docs (from previous commit)
cephalization
force-pushed
the
chore/upgrade-typescript
branch
from
26df07e to
dea4ac0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches build/typecheck scripts and TypeScript versions across the repo, which can cause CI/build breakage or new type errors. Changes are mostly mechanical and tooling-focused with minimal runtime impact.
Overview
Standardizes TypeScript tooling across
app/andjs/by upgradingapptotypescript@^5.9.3and removing per-package/example TypeScript devDependencies injsin favor of the workspace/root version.Renames typecheck scripts from
type:checktotypecheckthroughoutjspackages and updates thetypescript-packages-CIworkflow accordingly, plus extendspackage-version-checkCI to enforcetypescriptversion parity betweenapp/package.jsonandjs/package.json.Includes small TypeScript-5.9-driven code tweaks: replaces an outdated
@ts-ignorewith@ts-expect-errorin pointcloud code, removes an unnecessarystartViewTransitiontype suppression, and adds runtime string guards for toggle-group selection values.Written by Cursor Bugbot for commit dea4ac0. This will update automatically on new commits. Configure here.