update datasets dependency to >=3.0.2,<4.0.0 (results in 3.6.0)#213
Draft
ArneBinder wants to merge 19 commits intomainfrom
Draft
update datasets dependency to >=3.0.2,<4.0.0 (results in 3.6.0)#213ArneBinder wants to merge 19 commits intomainfrom
datasets dependency to >=3.0.2,<4.0.0 (results in 3.6.0)#213ArneBinder wants to merge 19 commits intomainfrom
Conversation
Draft
4 tasks
13d3fc2 to
9f383b7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
- Coverage 97.47% 93.62% -3.85%
==========================================
Files 5 10 +5
Lines 396 989 +593
==========================================
+ Hits 386 926 +540
- Misses 10 63 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
datasets dependencydatasets dependency to 3.6.0
datasets dependency to 3.6.0datasets dependency to >=3.0.2,<4.0.0 (results in 3.6.0)
…her dataset scripts)
…t_load_dataset_conll2003`
371b3bb to
707b06e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We require
>=3.0.2because of huggingface/datasets#7234, otherwise Brat datasets break (sincedatasets>=2.16.0).related: #93, #212
requires:
test_base_builderfor brat #215PieDatasetBuilder#216builderfixture #217empty_datasetfixtures future proof #218dataset scripts require:
BASE_DATASET_PATHs #219Changes:
trust_remote_code=Truein tests (required since datasets 2.20.0)test_load_dataset_conll2003(_single_split): passbase_dataset_kwargs=dict(trust_remote_code=True). This should not be necessary anymore once this is handled in theconll2003pie dataset scripttrust_remote_code=Trueper defaultpie_datasets.load_datasetand inpie_datasets.DatasetDict.load_datasetto stay backwards compatiblebuildertests since exception types and messages did change:test_builder_class_with_kwargs_wrong_parameterandtest_builder_class_with_base_dataset_kwargs_wrong_parameterDatasetDict.load_datasetintest_load_dataset_conll2003numpy = "<2.0.0",pyarrow = "^13", andfsspec = "<2023.9.0"Upgrade instructions: Adjust PIE dataset scripts to work with
trust_remote_codeif their base dataset requires it. Either{"trust_remote_code": True}for all config names andNonetoBASE_CONFIG_KWARGS_DICT, orpie_datasets.ArrowBasedBuilder(instead ofpie_datasets.GeneratorBasedBuilder).TODO:
conll2002,drugprotandsciarg), see use pie-datasets from branch update-datasets-dependency pytorch-ie-hydra-template-1#219Follow-ups:
poetry update