Add --no-urgent flag to send command#1933
Merged
AsamK merged 2 commits intoAsamK:masterfrom Feb 25, 2026
Merged
Conversation
Expose the server's `urgent` parameter so callers can skip sending a push notification (FCM/APNs) to the recipient. The message is still delivered in real-time over WebSocket if the recipient's app is active. The flag is added to the Message record (following the same pattern as viewOnce) and threaded through ManagerImpl and SendHelper, keeping the Manager interface unchanged.
Owner
|
Thanks, the code looks good. |
Align with the protocol naming as suggested by the maintainer. The flag controls the 'urgent' parameter on the server request.
kaikozlov
changed the title
Contributor
Author
|
Yes, I agree that |
AsamK
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-pushflag to thesendcommand that setsurgent=falseon the server request, skipping the FCM/APNs push notification to the recipientviewOncepattern by addingnoPushto theMessagerecord, keeping theManagerinterface unchangedTest plan
./gradlew buildpasses./gradlew testpasses--no-pushand verify recipient does not receive a push notification when app is backgrounded--no-pushand verify normal push behavior