Fix: preserve quote context when author is null or invalid#1941
Closed
joeykrug wants to merge 1 commit intoAsamK:masterfrom
Closed
Fix: preserve quote context when author is null or invalid#1941joeykrug wants to merge 1 commit intoAsamK:masterfrom
joeykrug wants to merge 1 commit intoAsamK:masterfrom
Conversation
Author
|
Closing due to other PR being a cleaner way to do this and more comprehensive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1935
Problem
When receiving a quoted/replied message, signal-cli silently drops the quote data if the quote author's ServiceId is null or fails the
isValid()check. This means consumers of the signal-cli API (JSON-RPC, D-Bus) never receive quote context for these messages.The root cause is an overly strict
.filter()on the quote Optional inMessageEnvelope.javathat discards the entire quote when the author can't be resolved, rather than preserving the quote with a fallback author.Fix
.filter(q -> q.getAuthor() != null && q.getAuthor().isValid())that drops quotes entirelyQuote.from(), handle null/invalid authors by falling back toRecipientAddress.UNKNOWN_UUIDOptional.ofNullable()for quote text (defensive)Testing
This fix has been tested in production with a source-built 0.14.0-SNAPSHOT: