Otel configuration for default metrics#3135
Conversation
Summary of ChangesHello @mukesh31994, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces OpenTelemetry auto-instrumentation to the Athenz UI, significantly enhancing its observability capabilities. By integrating OpenTelemetry, the application will now automatically collect and export data for HTTP requests, runtime metrics, and distributed traces, providing a comprehensive view of its performance and behavior for improved monitoring and debugging. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
ed8d8fa to
4d3a311
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces OpenTelemetry auto-instrumentation to Athenz UI, which is a great step towards better observability. The implementation is solid, but I have a few suggestions to enhance its robustness and align it with best practices. My feedback includes aligning OpenTelemetry package versions for stability, ensuring secure connections are enforced when configured, adding resource attributes for better telemetry identification, and implementing a graceful shutdown mechanism to prevent data loss.
c9608be to
6225014
Compare
Signed-off-by: msharma07 <mukesh.sharma@yahooinc.com>
Signed-off-by: msharma07 <mukesh.sharma@yahooinc.com>
Signed-off-by: msharma07 <mukesh.sharma@yahooinc.com>
Signed-off-by: msharma07 <mukesh.sharma@yahooinc.com>
Signed-off-by: msharma07 <mukesh.sharma@yahooinc.com>
Description
Add OpenTelemetry auto-instrumentation to Athenz UI for automatic monitoring of HTTP requests, runtime metrics, and distributed tracing.
Changes:
src/opentelemetry/instrumentation.mjsContribution Checklist:
Attach Screenshots