provide option for target role arn when storing lambda idenitty in se…

[havetisyan]

…cret manager

Description

Contribution Checklist:

• The pull request does not introduce any breaking changes
• I have read the contribution guidelines.
• Create an issue and link to the pull request.

Attach Screenshots (Optional)

[gemini-code-assist]

Summary of Changes

Hello @havetisyan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to how Lambda identities are stored in AWS Secrets Manager. It provides the flexibility to specify a target IAM role ARN, which the application will assume before interacting with Secrets Manager. This change is crucial for scenarios requiring secure cross-account or cross-role access, improving the overall security posture and operational flexibility for managing secrets.

Highlights

• Enhanced Secrets Manager Access: Added an option to specify a targetRoleArn when storing Lambda identity in AWS Secrets Manager, allowing the function to assume a different IAM role for accessing the secret.
• Cross-Account/Role Capability: Implemented logic to use AWS STS AssumeRoleProvider to obtain temporary credentials, enabling secure cross-account or cross-role access to Secrets Manager.
• API Update: Modified the StoreAthenzIdentityInSecretManagerCustomFormat function signature to include the new targetRoleArn parameter, with StoreAthenzIdentityInSecretManager updated for backward compatibility.

Changelog

• libs/go/sia/aws/lambda/lambda.go
  • Imported the stscreds package to support AWS STS role assumption.
  • Updated the StoreAthenzIdentityInSecretManager function to pass an empty string for the new targetRoleArn parameter, maintaining backward compatibility.
  • Modified the StoreAthenzIdentityInSecretManagerCustomFormat function signature to accept a targetRoleArn string.
  • Added conditional logic within StoreAthenzIdentityInSecretManagerCustomFormat to assume the specified targetRoleArn using STS credentials before interacting with AWS Secrets Manager.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds an option to specify a targetRoleArn when storing a Lambda identity in AWS Secrets Manager. This allows assuming an IAM role before interacting with Secrets Manager. The implementation correctly uses the AWS SDK v2 to handle role assumption. My review includes a suggestion to improve the robustness of the functions by propagating context.Context to handle cancellations and timeouts for network operations.